Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix pep508 logic assuming single-digit minor versions #874
@joshfriend, thanks for taking the time to put this together! I agree that this will eventually be a problem, however I have a quick note here. The initial patch is to a currently unmodified file from pip itself. Rather than keeping track of that on our end, it would be much better to get this merged upstream.
If you wouldn't mind opening a PR there, and seeing it through to merge, that would be really helpful. At that time, I think we can look at merging this. I'm going to close this out for now though since we're at least 3.5 years out from a 3.x release greater than 9. If it's not fixed before then, we'll know it when pip does. Please feel free to ping here when things are set up in the pip repo.
I somehow did not look at the file path and realize that, sorry
The PEP508 document also has it wrong.
I'll send a fix to pip first though, even if its a long ways away from being a problem :)