New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pep508 logic assuming single-digit minor versions #874

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@joshfriend
Contributor

joshfriend commented Oct 10, 2017

If the python version were to reach 3.10.0, the logic from pep508 would result in a python_version of 3.1 instead of 3.10

@nateprewitt

This comment has been minimized.

Show comment
Hide comment
@nateprewitt

nateprewitt Oct 10, 2017

Member

@joshfriend, thanks for taking the time to put this together! I agree that this will eventually be a problem, however I have a quick note here. The initial patch is to a currently unmodified file from pip itself. Rather than keeping track of that on our end, it would be much better to get this merged upstream.

If you wouldn't mind opening a PR there, and seeing it through to merge, that would be really helpful. At that time, I think we can look at merging this. I'm going to close this out for now though since we're at least 3.5 years out from a 3.x release greater than 9. If it's not fixed before then, we'll know it when pip does. Please feel free to ping here when things are set up in the pip repo.

Thanks again!

Member

nateprewitt commented Oct 10, 2017

@joshfriend, thanks for taking the time to put this together! I agree that this will eventually be a problem, however I have a quick note here. The initial patch is to a currently unmodified file from pip itself. Rather than keeping track of that on our end, it would be much better to get this merged upstream.

If you wouldn't mind opening a PR there, and seeing it through to merge, that would be really helpful. At that time, I think we can look at merging this. I'm going to close this out for now though since we're at least 3.5 years out from a 3.x release greater than 9. If it's not fixed before then, we'll know it when pip does. Please feel free to ping here when things are set up in the pip repo.

Thanks again!

@joshfriend

This comment has been minimized.

Show comment
Hide comment
@joshfriend

joshfriend Oct 10, 2017

Contributor

The initial patch is to a currently unmodified file from pip itself

I somehow did not look at the file path and realize that, sorry 😝

The PEP508 document also has it wrong.

I'll send a fix to pip first though, even if its a long ways away from being a problem :)

Contributor

joshfriend commented Oct 10, 2017

The initial patch is to a currently unmodified file from pip itself

I somehow did not look at the file path and realize that, sorry 😝

The PEP508 document also has it wrong.

I'll send a fix to pip first though, even if its a long ways away from being a problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment