New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of setup.py arguments for upload command #260

Merged
merged 1 commit into from Apr 6, 2017

Conversation

Projects
None yet
3 participants
@skirpichev
Contributor

skirpichev commented Aug 4, 2016

If sdist was invoked before bdist_wheel - upload first tries sdist upload
and some metadata on pypi will be missing (notable, Requires
Distributions section).

c.f.

$ python setup.py sdist bdist_wheel upload -r https://pypi.python.org/pypi
[...]
running upload
Submitting dist/Diofant-0.8.0a2.tar.gz to https://pypi.python.org/pypi
HTTP Error 400: This filename has previously been used, you should use a different version.
error: HTTP Error 400: This filename has previously been used, you should use a different version.

vs

$ python setup.py bdist_wheel sdist upload -r https://pypi.python.org/pypi
[...]
running upload
Submitting /home/sk/src/diofant/dist/Diofant-0.8.0a2-py3-none-any.whl to https://pypi.python.org/pypi
HTTP Error 400: This filename has previously been used, you should use a different version.
error: HTTP Error 400: This filename has previously been used, you should use a different version.

Not sure if it's not a bug for setuptools, but it works in this way for recent setuptools too (checked with 25.1.1).

Fix order of setup.py arguments for upload command
If sdist was invoked before bdist_wheel - upload first tries sdist upload
and some metadata on pypi will be missing (notable, Requires
Distributions section).

c.f.
$ python setup.py sdist bdist_wheel upload -r https://pypi.python.org/pypi
[...]
running upload
Submitting dist/Diofant-0.8.0a2.tar.gz to https://pypi.python.org/pypi
HTTP Error 400: This filename has previously been used, you should use a different version.
error: HTTP Error 400: This filename has previously been used, you should use a different version.

vs
$ python setup.py bdist_wheel sdist upload -r https://pypi.python.org/pypi
[...]
running upload
Submitting /home/sk/src/diofant/dist/Diofant-0.8.0a2-py3-none-any.whl to https://pypi.python.org/pypi
HTTP Error 400: This filename has previously been used, you should use a different version.
error: HTTP Error 400: This filename has previously been used, you should use a different version.

Not sure if it's not a bug for setuptools, but it works in this way for recent setuptools too (checked with 25.1.1).
@theacodes

This comment has been minimized.

Member

theacodes commented Apr 6, 2017

I'm okay with merging this as the change itself is trivial, however, I'm wondering if it's worthwhile to send a follow-up PR to document why this is necessary.

@jaraco (or anyone else) can you confirm the reason why metadata differs depending on the distribution type? Does it make a difference to pip for installation purposes?

@theacodes theacodes merged commit b7b867c into pypa:master Apr 6, 2017

@skirpichev skirpichev deleted the skirpichev:distributing-with-setuptools branch Apr 6, 2017

@jaraco

This comment has been minimized.

Member

jaraco commented May 2, 2017

I use sdist then bdist_wheel in all of my projects. I haven't had any complaints about metadata being missing. Moreover, when I look at a release I've made recently (here's the actual build log), it has the Requires-Distributions metadata, so this report seems to be invalid to me. Of course, things may have changed in the interim, but it's not apparent from the OP that there's an actual issue here.

@theacodes

This comment has been minimized.

Member

theacodes commented May 2, 2017

If someone can present a reproducible case where this occurs we can document why it's necessary.

Thanks for the confirmation, @jaraco.

ncoghlan added a commit to ncoghlan/python-packaging-user-guide that referenced this pull request Jun 24, 2017

Swap order of setup.py arguments for upload command (pypa#260)
If sdist was invoked before bdist_wheel - upload first tries sdist upload and some metadata on pypi will be missing (notable, Requires Distributions section).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment