New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that MANIFEST.in does not affect wheels #332

Merged
merged 2 commits into from Jun 23, 2017

Conversation

Projects
None yet
2 participants
@theacodes
Member

theacodes commented Jun 23, 2017

Resolves #306

@theacodes theacodes requested review from ddbeck and ncoghlan Jun 23, 2017

@ddbeck

I marked up a couple little formatting things. Otherwise, fine. Thanks!

@@ -90,21 +90,21 @@ MANIFEST.in
~~~~~~~~~~~
A "MANIFEST.in" is needed in certain cases where you need to package additional

This comment has been minimized.

@ddbeck

ddbeck Jun 23, 2017

Contributor

Since we're here anyway, can you put the file name in backticks (or use Sphinx's :file: role) to be consistent with the note below?

This comment has been minimized.

@theacodes
For details on writing a ``MANIFEST.in`` file, see the `The MANIFEST.in template
<https://docs.python.org/2/distutils/sourcedist.html#the-manifest-in-template>`_
section from the :ref:`distutils` documentation.
.. note:: ``MANIFEST.in`` does not affect binary distributions such as
``wheels``.

This comment has been minimized.

@ddbeck

ddbeck Jun 23, 2017

Contributor

I don't think "wheels" needs to be code formatted (bonus: it fixes the weird source formatting).

This comment has been minimized.

@theacodes

theacodes Jun 23, 2017

Member

yeah, good catch, leftover from when it was bdist_wheel.

@theacodes theacodes merged commit 631145e into pypa:master Jun 23, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@theacodes theacodes deleted the theacodes:manifest-not-wheel branch Jun 23, 2017

ncoghlan added a commit to ncoghlan/python-packaging-user-guide that referenced this pull request Jun 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment