New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata 2.1 updates #412

Merged
merged 5 commits into from Mar 4, 2018

Conversation

Projects
None yet
4 participants
@di
Member

di commented Dec 8, 2017

This PR captures all changes we need to make now that PEP 566 is accepted.

Fixes #410, fixes #411, closes #449.

(cc @takluyver)

@di di force-pushed the di:metadata-1.3-updates branch from 87982ad to 8fe8677 Dec 8, 2017


The name of the distributions.
^([A-Z0-9]|[A-Z0-9][A-Z0-9._-]*[A-Z0-9])$

This comment has been minimized.

@takluyver

takluyver Dec 8, 2017

Member

Is it worth adding a prose description of this as well? Here's some words we could use:

A valid name consists only of ASCII letters and numbers, period, underscore and hyphen. It must start and end with a letter or number.

@di di changed the title from Metadata 1.3 updates [WIP] to Metadata 2.1 updates [WIP] Feb 9, 2018

@ncoghlan

This comment has been minimized.

Member

ncoghlan commented Feb 24, 2018

PEP 566 has been accepted: python/peps@c839748

However, the PR requires a few updates to match the accepted version of the PEP:

  • metadata version is now 2.1
  • needs versionadded notes for Description-Content-Type and Provides-Extra
  • Description can now be the metadata body (and needs a versionchanged note for that)
  • Requires-Dist et al should have a versionchanged note for 2.1 that says something like: "The field format specification was relaxed to accept the syntax used by popular publishing tools. Metadata consumers may want to use the more relaxed formatting rules even for metadata files that are nominally version 1.2" (Alternatively, it may make sense to have a separate section on interpreting older metadata, and reduce the note on each field to just the first sentence about relaxing the rules to match common practices).

di and others added some commits Dec 4, 2017

@di di force-pushed the di:metadata-1.3-updates branch from 8fe8677 to f9dcd98 Mar 3, 2018

@di di changed the title from Metadata 2.1 updates [WIP] to Metadata 2.1 updates Mar 3, 2018

@di

This comment has been minimized.

Member

di commented Mar 3, 2018

@ncoghlan I think I've addressed all your points (thank you for the checklist, BTW). Could you review/merge?

@ncoghlan ncoghlan merged commit e634317 into pypa:master Mar 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ncoghlan

This comment has been minimized.

Member

ncoghlan commented Mar 4, 2018

Huzzah! I'll go mark the PEP as Final as well :)

ncoghlan added a commit to python/peps that referenced this pull request Mar 4, 2018

PEP 566: Mark as Final
pypa/python-packaging-user-guide#412 has been
merged, updating the core metadata specification to match the PEP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment