New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note which fields can be used with environment markers #416

Merged
merged 1 commit into from Dec 12, 2017

Conversation

Projects
None yet
2 participants
@takluyver
Member

takluyver commented Dec 12, 2017

PEP 345 lists six fields which can have environment markers. I've noted it for all six, but I don't know if I should. In particular, I've never seen a classifier listed with an environment marker, and it doesn't make much sense to me to allow that.

I've also updated the specification of Requires-Dist with a brief summary of PEP 508.

Closes gh-409

@theacodes

This comment has been minimized.

Member

theacodes commented Dec 12, 2017

Thanks @takluyver.

Re:

In particular, I've never seen a classifier listed with an environment marker, and it doesn't make much sense to me to allow that.

Perhaps @ncoghlan or @dstufft has some insight here.

I'm going to go ahead and merge- we can address post-hoc comments in a follow-up PR.

@theacodes theacodes merged commit f783620 into pypa:master Dec 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment