New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated content on 'installing scientific packages' page #455

Merged
merged 1 commit into from Mar 20, 2018

Conversation

Projects
None yet
4 participants
@waseem18
Contributor

waseem18 commented Mar 11, 2018

Fixes #383

@waseem18

This comment has been minimized.

Contributor

waseem18 commented Mar 11, 2018

@jonparrott Can you please review this?

Thanks

packages, it is not limited to just Python packages. It has full support for
native virtual environments. Conda makes environments first-class citizens,
making it easy to create independent environments even for C libraries. It is
written in Python, but is Python-agnostic. Conda manages python itself as a

This comment has been minimized.

@brainwane

brainwane Mar 11, 2018

Member

Quick question, why did you lower-case "python" here?

This comment has been minimized.

@waseem18

waseem18 Mar 11, 2018

Contributor

I missed it. Will Capitalize it

This comment has been minimized.

@waseem18

waseem18 Mar 11, 2018

Contributor

Addressed

@waseem18 waseem18 force-pushed the waseem18:scientific-packages branch from 929d9a6 to 5642436 Mar 11, 2018

@waseem18

This comment has been minimized.

Contributor

waseem18 commented Mar 11, 2018

@brainwane I missed changing Last Reviewed - changing it to today's date. What about Page Status? Currently it says Incomplete.

@ncoghlan

This comment has been minimized.

Member

ncoghlan commented Mar 12, 2018

I'm thinking those "Last Reviewed" and "Page Status" markers may have served their purpose now, and we'd be best off dropping them entirely.

IIRC, we added them back around 2014 when our tooling recommendations were sometimes changing from month to month as we discovered new problems with the various available options, and the PyPUG wasn't well enough known yet for corrections to be sent in as PRs.

@waseem18

This comment has been minimized.

Contributor

waseem18 commented Mar 12, 2018

Thanks for the response @ncoghlan . So shall I go ahead and remove Last Reviewed and Page Status ?

@ncoghlan

This comment has been minimized.

Member

ncoghlan commented Mar 12, 2018

@waseem18 Aye, go ahead.

@waseem18 waseem18 force-pushed the waseem18:scientific-packages branch from 5642436 to b8cdae2 Mar 12, 2018

@brainwane

This comment has been minimized.

Member

brainwane commented Mar 14, 2018

@waseem18 ready to be re-reviewed?

@waseem18

This comment has been minimized.

Contributor

waseem18 commented Mar 14, 2018

Yes @brainwane - I've removed the Last Reviewed and Page Status as per @ncoghlan 's review.

@brainwane

Tiny punctuation suggestion.

common denominator" and publishing that as a wheel file on PyPI.
Starting with version 1.10.4 of NumPy and version 1.0.0 of SciPy, pre-built
32-bit and 64-bit binaries in the ``wheel`` format are available for all major
operating systems (Windows, macOS, and Linux) on PyPI. Note however that on

This comment has been minimized.

@brainwane

brainwane Mar 18, 2018

Member

should be:

Note, however, that

This comment has been minimized.

@waseem18

waseem18 Mar 19, 2018

Contributor

Addressed.

Updated content on 'installing scientific packages' page
Capitalized 'Python'

Remove page status and last reviewed markers

Resolved code review

@waseem18 waseem18 force-pushed the waseem18:scientific-packages branch from b8cdae2 to 084524d Mar 19, 2018

@theacodes theacodes merged commit f1268b9 into pypa:master Mar 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment