Skip to content

Tests failing on Nightly Python builds #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jaraco opened this issue Apr 15, 2017 · 1 comment
Closed

Tests failing on Nightly Python builds #1015

jaraco opened this issue Apr 15, 2017 · 1 comment

Comments

@jaraco
Copy link
Member

jaraco commented Apr 15, 2017

Starting in this build, the tests seem to have started failing on the nightly builds, presumably due to a change in them.

@jaraco
Copy link
Member Author

jaraco commented Apr 18, 2017

Recommendations from the upstream issue:

I think that it would be better to not depend on exact result of re.escape. Either use re.escape for calculating the part of the expected result that is out of your full control:

assert get_pattern(l('foo/bar')) == l(re.escape('foo/bar') + r'\Z(?ms)')

Or test the pattern indirectly. For example, it should match 'foo/bar', but not 'foo/bar\n'.

Note that compiling the pattern r'foo/bar\Z(?ms)' emits a deprecation warning in 3.6+ since flags are not at the start of the expression. It is worth to rewrite get_pattern() until it become an error.

jaraco added a commit that referenced this issue Apr 18, 2017
jaraco added a commit that referenced this issue Apr 18, 2017
jaraco added a commit that referenced this issue Apr 18, 2017
@jaraco jaraco closed this as completed in 850555f Apr 19, 2017
jaraco added a commit that referenced this issue Apr 19, 2017
jaraco added a commit that referenced this issue Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant