Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Regression: sdists no longer install package data correctly with 35.0.0 #1016
I have a package that uses
With setuptools 34.4.1, installing an sdist will install these package data files without any problems. However, with setuptools 35.0.0, installing the same sdist file will no longer install these package data files.
As far as I can tell, this regression is due to #436 / #1014, which no longer reads the sdist package's existing manifest. When the manifest gets regenerated (?), the files that were previously included by
This was referenced
Apr 18, 2017
Here's a reproducing test script using cartridge-downloads, which uses
(Note that this uses
--- good-info 2017-04-18 16:25:18.364959212 +0200 +++ bad-info 2017-04-18 16:25:32.172929357 +0200 @@ -37,12 +37,6 @@ cartridge_downloads/models.py cartridge_downloads/page_processors.py cartridge_downloads/signals.py - cartridge_downloads/templates/email/form_response.html - cartridge_downloads/templates/email/form_response.txt - cartridge_downloads/templates/email/order_receipt.html - cartridge_downloads/templates/email/order_receipt.txt - cartridge_downloads/templates/shop/complete.html - cartridge_downloads/templates/shop/downloads/index.html cartridge_downloads/templatetags/__init__.py cartridge_downloads/templatetags/__pycache__/__init__.cpython-35.pyc cartridge_downloads/templatetags/__pycache__/downloads.cpython-35.pyc
As you can see, setuptools 35.0.0 no longer installs the
pyuri is another example of an affected package:
+ diff -u good-info bad-info --- good-info 2017-04-18 16:36:47.098278222 +0200 +++ bad-info 2017-04-18 16:36:53.994243434 +0200 @@ -19,5 +19,4 @@ pyuri/__pycache__/uri.cpython-35.pyc pyuri/__pycache__/validators.cpython-35.pyc pyuri/uri.py - pyuri/uri.regex pyuri/validators.py
Okay, I created an integration test case using
This test case passes on 34, and fails on 35.
If it looks good, I can PR that as a starting point for fixing this issue?