Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.cfg metadata doesnt correctly support setup_requires #1054

Closed
RonnyPfannschmidt opened this Issue Jun 5, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@RonnyPfannschmidt
Copy link
Contributor

RonnyPfannschmidt commented Jun 5, 2017

while experimenting with pushing all metadata into setup.cfg i noticed that when using setup_requires - the packages only seem to be considered when preinstalled or listed in setup.py

@FRidh

This comment has been minimized.

Copy link

FRidh commented Jun 5, 2017

Isn't this documented behavior?

(Note: projects listed in setup_requires will NOT be automatically installed on the system where the setup script is being run. They are simply downloaded to the ./.eggs directory if they’re not locally available already. If you want them to be installed, as well as being available when the setup script is run, you should add them to install_requires and setup_requires.)

https://setuptools.readthedocs.io/en/latest/setuptools.html#new-and-changed-setup-keywords

@RonnyPfannschmidt RonnyPfannschmidt changed the title setup.cfg metadata doesnt correctly support install_requires setup.cfg metadata doesnt correctly support setup_requires Jun 5, 2017

@RonnyPfannschmidt

This comment has been minimized.

Copy link
Contributor Author

RonnyPfannschmidt commented Jun 5, 2017

@FRidh please excuse - i made a mistake when writing the issue

setuptools 30.3.0 added support for putting setup.py supplied metadata into setup.cfg
i experimented with that and stumbled uppon various issues

@FRidh

This comment has been minimized.

Copy link

FRidh commented Jun 5, 2017

Could you share a setup.cfg? So you added the package to both setup_requires and install_requires, in either setup.cfg or setup.py?

@RonnyPfannschmidt

This comment has been minimized.

Copy link
Contributor Author

RonnyPfannschmidt commented Jun 6, 2017

@FRidh it didnt work when i added it only to setup.cfg - it worked when i added it to setup.py

the experiment is still on pytest-dev/apipkg#2

@althonos

This comment has been minimized.

Copy link

althonos commented Jun 29, 2017

+1, I am also having trouble with extension command (pytest-runner) in setup_requires being ignored from my setup.cfg, but works when defined in setup.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.