Version 38.5.0 fails to build extension #1271
Comments
I can reproduce. It looks like the issue is caused by 038baa1. The switch to @@ -1017,8 +1017,8 @@ from numpy import ma
from libc.string cimport memcpy, memset
from libc.stdlib cimport malloc, free
import_array()
-include "constants.pyx"
-include "netCDF4.pxi"
+include "include/constants.pyx"
+include "include/netCDF4.pxi"
IF HAS_NC_PAR:
cimport mpi4py.MPI as MPI
from mpi4py.libmpi cimport MPI_Comm, MPI_Info, MPI_Comm_dup, MPI_Info_dup, \ IMHO netCDF4' |
That commit references #1270. My expectation was that @scoder: Can you comment - is the switch from |
It does look like it's not compatible: see Cython's changelog. |
It looks like it also breaks the running build_ext
Traceback (most recent call last):
File "./setup.py", line 389, in <module>
cmdclass=cmdclass,
File ".../setuptools/setuptools/__init__.py", line 129, in setup
return distutils.core.setup(**attrs)
File "/usr/lib/python3.6/distutils/core.py", line 148, in setup
dist.run_commands()
File "/usr/lib/python3.6/distutils/dist.py", line 955, in run_commands
self.run_command(cmd)
File "/usr/lib/python3.6/distutils/dist.py", line 973, in run_command
cmd_obj.ensure_finalized()
File "/usr/lib/python3.6/distutils/cmd.py", line 107, in ensure_finalized
self.finalize_options()
File ".../setuptools/setuptools/command/build_ext.py", line 133, in finalize_options
_build_ext.finalize_options(self)
File "~/.local/lib/python3.6/site-packages/Cython/Distutils/build_ext.py", line 20, in finalize_options
super(build_ext, self).finalize_options()
TypeError: super(type, obj): obj must be an instance or subtype of type Which in turns break the |
Nevermind, that last issue is a bug in Cython 0.25.2, it works fine with 0.27.3. |
Thanks for the rollback. We had the same problem here. The I really think it is better to build the cython extensions at the build stage, but it is really a matter of point of view. If you still want to use |
@vallsv: just to be clear the change has not been (yet?) reverted. |
Oh sorry there is still no rollback :-) Then for more explanation, on our projects (https://github.com/silx-kit/pyFAI) we are cythonizing files by ourselves to have a little more features (manage cython cache, and portable openmp options). I try to move our code from |
With the revert and installing 38.5.1 travis tests are now passing again. Thanks. |
Same here. Thanks a lot. |
I first noticed this on a travis build for one of my projects. NetCDF4-python (one of my dependencies) fails to build when setuptools 38.5.0 is installed. Forcing the version to 38.4.0 fixes it. See https://travis-ci.org/pytroll/satpy/jobs/337509200#L940 for the failed job which ends with this exception:
See here for a working build where I forced setuptools to 38.4.0: https://travis-ci.org/pytroll/satpy/jobs/337598254#L863
I'm hoping that this is enough to get someones attention that knows what's wrong, but if a smaller example is needed I can try to work that out.
The text was updated successfully, but these errors were encountered: