-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Regression 38.7.0: ascii decode error when installing package from source #1297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Changelog indicates that change was to add the maintainer to the package metadata (#1288). My guess is these packages had non-ascii values in these fields and simply including them means we need to deal with the non-ascii values. @pganssle Can you investigate? |
Indeed the package has A with acute in author's name, https://github.com/file/file/blob/master/python/setup.py#L10 |
Very strange because I actually test for this, not sure why my test didn't catch this. |
Probably because of https://github.com/pypa/setuptools/blob/master/setuptools/tests/test_dist.py#L1 |
This does actually look like the errors I was getting on Python 2.7 when I was using I'll change the test over to use @asavah Good call on the encoding - I was assuming that did not matter because the strings to encode were not in that file, but I think the fact that the strings being formatted are being taken as ASCII is what's throwing this off. I'll test this out and send in a new PR. Sorry about the fuss. As an aside, I actually met the author whose name is causing the problem (@turicas) after this talk at PyCon, about how dealing with text/unicode is difficult, coincidentally enough. |
Changing the encoding on the |
Found the problem. On Python 2.7 there is an |
Release going out as v39.0.1. Please test and report back if a backport to v38 is required. |
When installing https://github.com/file/file/blob/master/python/ from source
python 2.7.14
setuptools 38.7.0
fails:
Setuptools 38.6.0 works fine.
Edit: python 3.6.4 + setuptools 38.7.0 also works fine.
The text was updated successfully, but these errors were encountered: