/setuptools

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR template #1355

Closed
pganssle opened this Issue May 14, 2018 · 2 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
2 participants
@pganssle @seawolf42
@pganssle
Member

pganssle commented May 14, 2018

It would be good to add a PR template similar to what we're doing on dateutil.

The important features are:

  • PR includes tests
  • PR includes news fragment (link to the developer guide)

@pganssle pganssle added the good first issue label May 14, 2018

pganssle added a commit to Zelgius/setuptools that referenced this issue May 15, 2018

@Zelgius @pganssle
Update developer guide documentation 
Add changelog for PR pypa#1363 (issue pypa#1355)
30dfce4

Zelgius added a commit to Zelgius/setuptools that referenced this issue May 15, 2018

@Zelgius
Update developer guide documentation 
Add changelog for PR pypa#1363 (issue pypa#1355)
Verified
This commit was signed with a verified signature.
@Zelgius Zelgius Mason Egger
GPG key ID: CF4183856E4EE74C Learn about signing commits
a72e997
@seawolf42

This comment has been minimized.

Sign in to view
Contributor

seawolf42 commented May 15, 2018

Looks like this was addressed in #1363?
@pganssle

This comment has been minimized.

Sign in to view
Member

pganssle commented May 15, 2018

@seawolf42 Yes. Thanks @Zelgius!

@pganssle pganssle closed this May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment