/setuptools

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.8 urllib.parse.splituser DeprecationWarning #1499

Closed
tirkarthi opened this Issue Sep 21, 2018 · 1 comment

Comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@tirkarthi @pganssle @jaraco
@tirkarthi
Copy link

tirkarthi commented Sep 21, 2018

Using setuptools on CPython master (Python 3.8) generates below warning. Just wanted to give a heads up on this.

Relevant commit : python/cpython@0250de4

/home/karthi/requests-html-env/lib/python3.8/site-packages/setuptools/package_index.py:1049: DeprecationWarning: urllib.parse.splituser() is deprecated as of 3.8, use urllib.parse.urlparse() instead
  auth, host = urllib.parse.splituser(netloc)

Relevant code :

setuptools/setuptools/package_index.py

Line 1057 in e0433cf

auth, host = urllib.parse.splituser(netloc)

Thanks

jaraco added a commit that referenced this issue Sep 23, 2018

@jaraco
Remove use of splituser in packag_index.py. Fixes #1499.
Loading status checks…
a968ed6

@jaraco jaraco referenced this issue Sep 23, 2018

Merged

Remove use of splituser #1501

@pganssle pganssle added the bug label Oct 6, 2018

@pganssle pganssle added Needs Implementation and removed Needs Implementation labels Oct 19, 2018

@pganssle

This comment has been minimized.

Sign in to view
Copy link
Member

pganssle commented Oct 23, 2018 •
edited

PR #1501 solves this, but it is blocked on #1504.

@pganssle pganssle referenced this issue Oct 25, 2018

Closed

Add unit tests for _download_url? #1504

@jaraco jaraco closed this Dec 14, 2018

@jaraco jaraco reopened this Dec 14, 2018

jaraco added a commit that referenced this issue Dec 16, 2018

@jaraco
Remove use of splituser in packag_index.py. Fixes #1499.
3a351aa

@jaraco jaraco closed this in #1501 Dec 16, 2018

jaraco added a commit that referenced this issue Feb 3, 2019

@jaraco
Revert to using a copy of splituser from Python 3.8. Using urllib.par… 
…se.urlparse is clumsy and causes problems as reported in #1663 and #1668. Alternative to #1499 and fixes #1668.
Loading status checks…
0830a69

@jaraco jaraco referenced this issue Feb 3, 2019

Merged

Revert to using a copy of splituser from Python 3.8. #1670

1 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment