Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for downloading from SVN #1502

Open
jaraco opened this issue Sep 23, 2018 · 3 comments
Open

Remove support for downloading from SVN #1502

jaraco opened this issue Sep 23, 2018 · 3 comments

Comments

@jaraco
Copy link
Member

@jaraco jaraco commented Sep 23, 2018

I was just going to leave the functionality, but because it's relying on deprecated functionality (splituser), I'm ready to just strip it out. First, deprecate, then remove.

jaraco added a commit that referenced this issue Sep 23, 2018
…ing instead of DeprecationWarning so it's visible to users who might be relying on this functionality.
@pganssle
Copy link
Member

@pganssle pganssle commented Sep 24, 2018

I think the ideal deprecation points to "here's the correct way to do this". Is the deprecation going to be, "Migrate to something other than SVN", or something else?

I'm wondering if we can do something like adding a "download from svn" that does git svn to a temporary directory so that the essential functionality is preserved with minimal maintenance burden.

@jaraco
Copy link
Member Author

@jaraco jaraco commented Sep 24, 2018

the ideal deprecation points to "here's the correct way to do this"

Whole-heartedly agree.

The whole of package_index and easy_install is deprecated, but it will be harder to remove. The guidance should be to use pip install for everything, and install from package indexes like PyPI or a devpi instance.

My presumption is this functionality is no longer actively used... and the deprecation will help identify if there are.

do something like git svn

Interesting idea. The main issue I had was the handling of the SVN URLs - there's special parsing of the URL there that I don't understand.

@pganssle
Copy link
Member

@pganssle pganssle commented Sep 24, 2018

Interesting idea. The main issue I had was the handling of the SVN URLs - there's special parsing of the URL there that I don't understand.

How does pip handle this if you use pip install svn+...? Can we just pull in their solution in order to continue supporting this until easy_install is gone completely?

I am not opposed to starting with deprecating this, particularly if no one is using it, but if the alternative is "use pip", then I think if we're doing selective deprecation, I'd prefer if it were driven by, "There are no known use cases for this particular thing that pip doesn't cover" rather than "We don't want to keep supporting this weird subset anymore even though we're maintaining the rest of the deprecated package". It's completely fair to say "none of us use SVN, it's a super niche use and we want to warn them early because they're even more likely to hit bugs that we're not going to fix soon".

Sorry if this comes off as very wishy-washy, just trying to explore our options out loud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants