Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uplicense field in setup.cfg should not accept file: #1551
Comments
pganssle
added
bug
help wanted
good first issue
Needs Implementation
labels
Oct 28, 2018
pganssle
added this to Help Wanted
in PyPA Sprint Weekend at Bloomberg (2018)
Oct 28, 2018
This comment has been minimized.
This comment has been minimized.
I'd like to work on this as a part of the bloomberg pypa sprint |
pganssle
moved this from Help Wanted
to In progress
in PyPA Sprint Weekend at Bloomberg (2018)
Oct 28, 2018
pganssle
referenced this issue
Oct 28, 2018
Merged
Setuptools will install licenses if included in setup.cfg #1536
added a commit
to RajdeepRao/setuptools
that referenced
this issue
Dec 29, 2018
pganssle
closed this
in
#1559
Dec 31, 2018
PyPA Sprint Weekend at Bloomberg (2018)
automation
moved this from In progress
to Closed Issues
Dec 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
pganssle commentedOct 28, 2018
•
edited
As brought to my attention by this comment, it seems that in
setup.cfg
,license
accepts afile:
, and the docstring of_parse_file
even mentionsfile: LICENSE
. I think this was based on a misunderstanding of what thelicense
file does, and I think will lead to problems with #1390 if actually used this way.We should remove support for
file:
in the license field.To do on this:
file:
support from the code. I'd start with just removing it and seeing what error is raised if you havefile:
in there, but if the error message is confusing, we need to add a "throw error if it'sfile:
" parser.file:
from the setup.cfg documentation.license: Apache 2.0
license: file:
throws an exception (Maybe?)