New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v40.7.1 omits port in index download #1663

Closed
kokoska69 opened this Issue Jan 31, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@kokoska69
Copy link

kokoska69 commented Jan 31, 2019

In this commit 3a351aa is used host instead of netloc, but host does not contain port. Version 40.6.3 works OK.

@jaraco

This comment has been minimized.

Copy link
Member

jaraco commented Feb 1, 2019

Sorry about the regression. After re-reading the diff, I can see the issue, which was probably brought on by the naming of 'host' when it meant 'netloc'. Fix should be straightforward.

jaraco added a commit that referenced this issue Feb 1, 2019

Ensure a specified port in package_index isn't lost in the parse/unpa…
…rse of the URL when auth is present. Fixes #1663.

@jaraco jaraco referenced this issue Feb 1, 2019

Merged

Ensure port is included in package-index #1665

1 of 2 tasks complete

@jaraco jaraco closed this in #1665 Feb 1, 2019

@jaraco jaraco referenced this issue Feb 1, 2019

Merged

Bugfix/1663 restore port #1666

1 of 2 tasks complete

jaraco added a commit that referenced this issue Feb 3, 2019

Revert to using a copy of splituser from Python 3.8. Using urllib.par…
…se.urlparse is clumsy and causes problems as reported in #1663 and #1668. Alternative to #1499 and fixes #1668.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment