Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v40.7.1 omits port in index download #1663

Closed
kokoska69 opened this issue Jan 31, 2019 · 1 comment
Closed

v40.7.1 omits port in index download #1663

kokoska69 opened this issue Jan 31, 2019 · 1 comment

Comments

@kokoska69
Copy link

@kokoska69 kokoska69 commented Jan 31, 2019

In this commit 3a351aa is used host instead of netloc, but host does not contain port. Version 40.6.3 works OK.

@jaraco
Copy link
Member

@jaraco jaraco commented Feb 1, 2019

Sorry about the regression. After re-reading the diff, I can see the issue, which was probably brought on by the naming of 'host' when it meant 'netloc'. Fix should be straightforward.

jaraco added a commit that referenced this issue Feb 1, 2019
…rse of the URL when auth is present. Fixes #1663.
@jaraco jaraco mentioned this issue Feb 1, 2019
1 of 2 tasks complete
@jaraco jaraco closed this in #1665 Feb 1, 2019
@jaraco jaraco mentioned this issue Feb 1, 2019
1 of 2 tasks complete
jaraco added a commit that referenced this issue Feb 3, 2019
…se.urlparse is clumsy and causes problems as reported in #1663 and #1668. Alternative to #1499 and fixes #1668.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants