Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move simple constants from setup.py into setup.cfg #1697

Closed
pganssle opened this issue Feb 22, 2019 · 1 comment

Comments

@pganssle
Copy link
Member

commented Feb 22, 2019

Currently we specify a lot of string literals in our setup.py. We're trying to encourage people to use declarative build configurations wherever possible, so we might as well start off at home move as much as we can over to setup.cfg. Should be almost everything that is a simple string literal.

So in our setup.py, I would say we can move everything except:

  1. dependency_links (Though I actually have no idea why those are in there in the first place)
  2. entry_points: which dynamically reads the possible commands from some location somewhere.
  3. package_data: Not sure what is going on with this, but it actually seems dangerous for our universal wheels produced on Linux... For now let's leave it alone.
@hpandeycodeit

This comment has been minimized.

Copy link

commented Feb 23, 2019

@pganssle I will work on this

@pganssle pganssle moved this from Open to In progress in HackIllinois 2019 Feb 23, 2019

venthur added a commit to venthur/setuptools that referenced this issue May 14, 2019

@venthur venthur referenced this issue May 14, 2019

Merged

Migrate constants from setup.py to setup.cfg #1761

2 of 2 tasks complete

pganssle added a commit to venthur/setuptools that referenced this issue May 15, 2019

Migrate constants from setup.py to setup.cfg
This also makes wheel an unconditional setup_requires dependency.

Closes: pypa#1697

pganssle added a commit to venthur/setuptools that referenced this issue May 15, 2019

Migrate constants from setup.py to setup.cfg
This also makes wheel an unconditional setup_requires dependency.

Closes: pypa#1697

pganssle added a commit to venthur/setuptools that referenced this issue May 15, 2019

Migrate constants from setup.py to setup.cfg
This also makes wheel an unconditional setup_requires dependency.

Closes: pypa#1697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.