Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
subversion revision tagging fails in setuptools 3.4.3 with subversion 1.8.x (patch) #185
Originally reported by: cazabon (Bitbucket: cazabon, GitHub: Unknown)
In a Python 2.7.6 virtualenv with setuptools 3.4.3 installed, setuptools fails to extract the svn revision from a package in an svn working copy checkout under these conditions:
This appears to be due to this test failing, in egg_info.py's tags():
I'll attach a patch which fixes the problem for me -- basically calling get_svn_revision() whenever tag_svn_revision is set, and using the result if it's not 0.
Original comment by philip_thiem (Bitbucket: philip_thiem, GitHub: Unknown):
Yeah this looks like a hold over from the old 1.6 and earlier only code. I would expect tagging to fail also with 1.7.x. I think the patch is fine. +1
There will be a warning whenever svn is not installed, but since it needs "--tag-svn-revision" which clearly svn related, I don't think we have to worry about breaking non-svn unittest setups when the command isn't present.
After a quick grep, I am thinking we might want to do a tag-svn-revision regression test. I can do that and run it on svn 1.3-1.8 before pushing out to travis.