subversion revision tagging fails in setuptools 3.4.3 with subversion 1.8.x (patch)

[ghost]

Originally reported by: cazabon (Bitbucket: cazabon, GitHub: Unknown)

---

https://mail.python.org/pipermail/distutils-sig/2014-April/024135.html

In a Python 2.7.6 virtualenv with setuptools 3.4.3 installed, setuptools fails to extract the svn revision from a package in an svn working copy checkout under these conditions:

• subversion 1.8.x
• python package is in a subdirectory of the working copy checkout, so there is no .svn dir in the package's dir due to subversion keeping it all in a single place in the root of the working copy

This appears to be due to this test failing, in egg_info.py's tags():

    if self.tag_svn_revision and (
        os.path.exists('.svn') or os.path.exists('PKG-INFO')
    ):

I'll attach a patch which fixes the problem for me -- basically calling get_svn_revision() whenever tag_svn_revision is set, and using the result if it's not 0.

---

• Bitbucket: https://bitbucket.org/pypa/setuptools/issue/185

[ghost]

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):

---

I hope Philip can review this patch.

[ghost]

Original comment by philip_thiem (Bitbucket: philip_thiem, GitHub: Unknown):

---

Yeah this looks like a hold over from the old 1.6 and earlier only code. I would expect tagging to fail also with 1.7.x. I think the patch is fine. +1

There will be a warning whenever svn is not installed, but since it needs "--tag-svn-revision" which clearly svn related, I don't think we have to worry about breaking non-svn unittest setups when the command isn't present.

After a quick grep, I am thinking we might want to do a tag-svn-revision regression test. I can do that and run it on svn 1.3-1.8 before pushing out to travis.

[ghost]

Original comment by philip_thiem (Bitbucket: philip_thiem, GitHub: Unknown):

---

Pending pull request #57

[ghost]

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):

---

Fixes Issue #185: Svn not working on new style svn metadata.

[ghost]

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):

---

This is going out as 5.3.