Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The setuptools 45 wheel has an incorrect py2.py3 tag #1974

Closed
sbidoul opened this issue Jan 18, 2020 · 2 comments
Closed

The setuptools 45 wheel has an incorrect py2.py3 tag #1974

sbidoul opened this issue Jan 18, 2020 · 2 comments

Comments

@sbidoul
Copy link
Member

@sbidoul sbidoul commented Jan 18, 2020

Arriving from pypa/pip#7610.

The wheel for setuptools 45 on PyPI has the py2.py3 tag in its file name.

Since that version does not support python 2 it should have the py3 tag.

@jaraco
Copy link
Member

@jaraco jaraco commented Jan 19, 2020

I have several concerns with the proposed solution (#1977, #1978) to remove the 'universal' indicator.

  • The indicator is meant to indicate the applicability of the package to the wheel to the target platform, and since this wheel does still have Python 2 compatibility in the source, it's technically still correct to advertise the wheel as universal.
  • The fact that pip happens to use this setting as a proxy for applicable packages in find-links (and ignores python-requires) feels like a bit of a hack.
  • This package does correctly declare its Python support in two ways (through Requires-Python and through Trove classifiers), so this is a third way to declare the package's Python support.

And if you loop in #1972, this requirement demands that moving a package from Python 2/3 support to Python 3-only support requires many changes:

  • update python_requires
  • remove Python 2 from Trove classifiers
  • add Python 3 Only to Trove classifiers
  • drop universal wheel

That seems like a awful lot of (redundant) steps for a single operation. It's enough work with enough opportunities to get it wrong that it probably demands some documentation. I'll implement these changes in my jaraco/skeleton project to apply to the other projects I maintain that have dropped Python 2 support.

@jaraco
Copy link
Member

@jaraco jaraco commented Jan 19, 2020

Fixed with #1978.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants