Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendored packaging to 20.4 (latest release) #2310

Closed
mattip opened this issue Aug 7, 2020 · 1 comment · Fixed by #2327
Closed

Update vendored packaging to 20.4 (latest release) #2310

mattip opened this issue Aug 7, 2020 · 1 comment · Fixed by #2327

Comments

@mattip
Copy link
Contributor

mattip commented Aug 7, 2020

In the interests of moving PEP 600 (xref tracking issue pypa/manylinux#542) forward, what is "protocol" for updating the vendored version of packaging to 20.4 (which includes parsing for the PEP 600 manylinux spec)? Are there checks or tests that need updating as well?

@jaraco
Copy link
Member

jaraco commented Aug 10, 2020

The protocol is mostly ad-hoc, but it's basically:

  • check for any backward-incompatible changes advertised by the vendored package and account for those in the codebase.
  • update the vendored package declaration (both in pkg_resources and setuptoools)
  • run the paver update_vendored routine.
  • commit the changes, run the tests, fix any issues, submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants