New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_py does not handle package_data properly #261

Closed
bb-migration opened this Issue Sep 29, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@bb-migration

bb-migration commented Sep 29, 2014

Originally reported by: sa2ajj (Bitbucket: sa2ajj, GitHub: sa2ajj)


In my project I use a pattern that would match directories as well:

#!python

package_data={
    '': ['path/*']
}

As a result, setuptools fails as it can't copy directories.

After a bit of investigation, I found that the problematic code is in build_py. While checking the content of distutils (which is part of CPython), the corresponding code looks different and it does not fail.


@bb-migration

This comment has been minimized.

bb-migration commented Dec 30, 2014

Original comment by sa2ajj (Bitbucket: sa2ajj, GitHub: sa2ajj):


Any updates?

@bb-migration

This comment has been minimized.

bb-migration commented Dec 30, 2014

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


I haven't had a chance to look into this. Looking at it briefly, it looks as if all that needs to happen is to ensure that directories are excluded from the files list. Would you be able to put together a pull request?

jaraco added a commit that referenced this issue May 22, 2016

jaraco added a commit that referenced this issue May 22, 2016

jaraco added a commit that referenced this issue May 22, 2016

@jaraco jaraco closed this in 8f0ac47 May 22, 2016

@jaraco

This comment has been minimized.

Member

jaraco commented May 22, 2016

As you can see above, efecaf8 tests fail, capturing the error that presumably would have been observed in the OP's case, and demonstrating the fix in 8f0ac47.

jaraco added a commit that referenced this issue May 22, 2016

tomprince added a commit to tomprince/buildbot that referenced this issue Jul 6, 2016

tardyp added a commit to buildbot/buildbot that referenced this issue Jul 7, 2016

@zmwangx zmwangx referenced this issue Jul 20, 2016

Closed

grip 4.3.0 (new formula) #3166

4 of 4 tasks complete

@mpharrigan mpharrigan referenced this issue Aug 25, 2016

Merged

project templates build fix #882

1 of 3 tasks complete

tardyp added a commit to buildbot/buildbot-contrib that referenced this issue Feb 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment