Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ssl.match_hostname is deprecated #2715

Closed
1 task done
jaraco opened this issue Jul 4, 2021 · 3 comments · Fixed by #2716
Closed
1 task done

[BUG] ssl.match_hostname is deprecated #2715

jaraco opened this issue Jul 4, 2021 · 3 comments · Fixed by #2716
Labels

Comments

@jaraco
Copy link
Member

jaraco commented Jul 4, 2021

setuptools version

main

Python version

3.10b something

OS

CI

Additional environment information

No response

Description

After merging jaraco/skeleton, which includes running tests on Python 3.10, some deprecation warnings manifest as errors: https://github.com/pypa/setuptools/runs/2984838195

Expected behavior

Setuptools should be deprecation-free.

How to Reproduce

Follow the CI steps.

Output

n/a

Code of Conduct

  • I agree to follow the PSF Code of Conduct
@jaraco jaraco added bug Needs Triage Issues that need to be evaluated for severity and status. labels Jul 4, 2021
@jaraco
Copy link
Member Author

jaraco commented Jul 4, 2021

Hmm. When I run the tests locally, I don't get the deprecation warnings.

@jaraco
Copy link
Member Author

jaraco commented Jul 4, 2021

Aha. The tests that are failing were skipped locally because my environment wasn't configured with viable root certs. After configuring those root certs, the tests are now running and failing similarly locally.

@jaraco jaraco changed the title [BUG] Deprecation warnings on Python 3.10 [BUG] ssl.match_hostname is deprecated Jul 4, 2021
@jaraco
Copy link
Member Author

jaraco commented Jul 4, 2021

The errors are all for ssl.match_hostname, which was deprecated in Python 3.7.

After some analysis of the ssl_support module, it seems that most of that module is around providing backward compatibility for ssl.match_hostname. Perhaps that module is no longer needed.

jaraco added a commit that referenced this issue Jul 4, 2021
@jaraco jaraco removed the Needs Triage Issues that need to be evaluated for severity and status. label Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant