Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Deprecate support for custom commands inheriting from distutils #2856

Closed
1 task done
abravalheri opened this issue Nov 5, 2021 · 0 comments · Fixed by #2857
Closed
1 task done

[FR] Deprecate support for custom commands inheriting from distutils #2856

abravalheri opened this issue Nov 5, 2021 · 0 comments · Fixed by #2857
Labels
enhancement Needs Triage Issues that need to be evaluated for severity and status.

Comments

@abravalheri
Copy link
Contributor

What's the problem this feature will solve?

From #2849, it is clear that many projects still inherit directly from distutils when creating customised commands.

As per PEP 632 this practice is deprecated for Python >= 3.10. But even in previous versions, it has been discouraged for a while.

We should encourage people to move away from it, by officially issuing deprecation.

Describe the solution you'd like

In #2855, a warning message is already being printed, however as discussed in #2855 (comment), there is a clear advantage in using warnings:

I'm unsure whether to invoke log.warn here or issue a DeprecationWarning. The latter can be controlled by warnings filters. In any case, I quite like the approach taken here to direct the users away from using distutils, which is deprecated.

_Originally posted by @jaraco

Alternative Solutions

No response

Additional context

No response

Code of Conduct

  • I agree to follow the PSF Code of Conduct
@abravalheri abravalheri added enhancement Needs Triage Issues that need to be evaluated for severity and status. labels Nov 5, 2021
@abravalheri abravalheri changed the title [FR] [FR] Deprecate support for custom commands inheriting from distutils Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Needs Triage Issues that need to be evaluated for severity and status.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant