Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Replace binary images with SVG #2867

Closed
1 task done
abravalheri opened this issue Nov 10, 2021 · 0 comments · Fixed by #2869
Closed
1 task done

[Docs] Replace binary images with SVG #2867

abravalheri opened this issue Nov 10, 2021 · 0 comments · Fixed by #2869
Assignees
Labels
documentation Needs Triage Issues that need to be evaluated for severity and status.

Comments

@abravalheri
Copy link
Contributor

Summary

According to

I'd recommend not to add blobs into the repo. Sphinx and any other modern web tool works with SVG just fine. Besides poisoning the Git bare repo size, it can also look ugly when scaled for folks with 200% default browser zoom (I have this, for example) + SVG is more optimized for the network transfer meaning faster page loads.

Originally posted by @webknjaz in #2853 (comment)

The best approach is to have all SVG images, and preferably remove binary files from the git repo.

OS / Environment

No response

Additional Information

There is some discussion in #2853.

According to https://caniuse.com/link-icon-svg, not all the browsers support SVG, however, a recent article seems to indicate that Safari does support it, which means that all major desktop browsers are covered.

Code of Conduct

  • I agree to follow the PSF Code of Conduct
@abravalheri abravalheri added documentation Needs Triage Issues that need to be evaluated for severity and status. labels Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Needs Triage Issues that need to be evaluated for severity and status.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant