Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need test for ResourceManager.get_cache_path #30

Closed
ghost opened this issue Jul 2, 2013 · 2 comments
Closed

Need test for ResourceManager.get_cache_path #30

ghost opened this issue Jul 2, 2013 · 2 comments

Comments

@ghost
Copy link

@ghost ghost commented Jul 2, 2013

Originally reported by: jaraco (Bitbucket: jaraco, GitHub: jaraco)


In #28 and Distribute #375, a regression was reported where an attribute was mis-named. Since this behavior wasn't covered by unit tests, the error was not discovered until the users experienced it.

Let's add one or more unit tests for ResourceManager.get_cache_path to ensure this doesn't occur again.


@ghost
Copy link
Author

@ghost ghost commented Jul 2, 2013

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


In 51ecba19369f, I added a test.

@ghost
Copy link
Author

@ghost ghost commented Jul 2, 2013

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


I created #31 to address the issue that these tests aren't run by default.

@ghost ghost added minor bug labels Mar 29, 2016
@ghost ghost closed this Mar 29, 2016
jaraco added a commit that referenced this issue Mar 29, 2016
Setuptools now honors all dependency_links and not just the first one that was supplied.
jaraco added a commit that referenced this issue Jan 16, 2021
* Replace pep517.build with build

Resolves #30

* Prefer simple usage

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
jaraco added a commit that referenced this issue Jan 16, 2021
* Use `extend-ignore` in flake8 config

This option allows to add extra ignored rules to the default list
instead of replacing it.

The default exclusions are: E121, E123, E126, E226, E24, E704,
W503 and W504.

Fixes #28.

Refs:
* https://github.com/pypa/setuptools/pull/2486/files#r541943356
* https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-extend-ignore
*
https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-ignore

* Enable complexity limit. Fixes jaraco/skeleton#34.

* Replace pep517.build with build (#37)

* Replace pep517.build with build

Resolves #30

* Prefer simple usage

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

* Use license_files instead of license_file in meta (#35)

Singular `license_file` is deprecated since wheel v0.32.0.

Refs:
* https://wheel.readthedocs.io/en/stable/news.html
* https://wheel.readthedocs.io/en/stable/user_guide.html#including-license-files-in-the-generated-wheel-file

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
0 participants