New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntryPoint.parse is too narrow minded? #327

Closed
bb-migration opened this Issue Jan 6, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@bb-migration

bb-migration commented Jan 6, 2015

Originally reported by: Anonymous


After having updated from 11.1 to 11.3 I experienced problems with the Bitten plugin for Trac. The error message was:

Error

TracError: ValueError: ("EntryPoint must be in 'name=module:attrs [extras]' format", 'http://bitten.cmlenz.net/tools/c#autoreconf = bitten.build.ctools:autoreconf')

The EntryPoint definition is not understood by the parser.

I have identified this change as the culprit.

The previous parser basically accepted everything that was not a = on the left hand side of the =. The regex based version started out with only accepting \w. Later + . were added but there might still be projects out there that use entry point definitions with other characters. For full compatibility with the old format the Regex should probably contain [^=].

While researching this problem I found a lack of clear definition how the entry point definition should be formatted (apart from name = module:attribute [extra1, extra2]) which explains the inconsistency in usage and parsing. Maybe this should be made more clear?


@bb-migration

This comment has been minimized.

bb-migration commented Jan 6, 2015

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


Agreed. There were lots of assumptions in the previous parsing. I should probably have been more lenient about name parsing to start. I'll fix it straight away.

@bb-migration

This comment has been minimized.

bb-migration commented Jan 6, 2015

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


Restore support for printable characters in the entry point name. Fixes #327.

@bb-migration

This comment has been minimized.

bb-migration commented Jan 6, 2015

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


Released as 11.3.1. Let me know if a 10.2.2 is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment