Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Test suite fails for the 14.0 release #360
As mentioned at the bottom of #359, the 14.0 release is exhibiting test suite failures https://kojipkgs.fedoraproject.org//work/tasks/2236/9162236/build.log
I believe I understand the nature of these failures. In all three cases, the errors are triggered in
The first failure is
The second failure is
The third failure is
This last issue should be resolved by digging into the test and its origin and determining if the test is still relevant in light of the 14.0 release.
The first two failures probably need to be addressed by factoring out the write test from the finalize_options. I'm not sure what the spec is for putting behavior in
In all cases, this won't be an easy fix, and I don't know when I'll get to it. @bubla, can you help with the failing tests?
For what it's worth, except for the behavior noted in the 14.0 release notes, the failing tests can be disregarded.
What's the impact of the failing tests with kojipkgs?
So long as they can be safely disregarded, the impact for us is not all that high. We would have to simply disable our run of the tests in our packaging process, but importantly, remember to re-enable it for future releases. It's just a helpful check for us to make sure we're not accidentally packaging something that is certain to not work for end users.
Impact level: manageable nuisance.
Thanks for the thorough reply. Should we leave the ticket open until its fully resolved? I can help test future iterations if you like.
I would like to help, but this is more about the internals of the