Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd failure on 18.3 (missing files, but they are there) #425

Closed
ghost opened this issue Sep 6, 2015 · 6 comments
Closed

Odd failure on 18.3 (missing files, but they are there) #425

ghost opened this issue Sep 6, 2015 · 6 comments
Labels

Comments

@ghost
Copy link

@ghost ghost commented Sep 6, 2015

Originally reported by: ionelmc (Bitbucket: ionelmc, GitHub: ionelmc)


I got this minboggling failure on travis: https://travis-ci.org/ionelmc/pytest-benchmark/jobs/79025407

If I force 18.2 it works fine: https://travis-ci.org/ionelmc/pytest-benchmark/jobs/79030569

Doesn't looks like setuptools might cause that but the downgrade solves it. Any idea about what's going on?

AFAIK pip will use the correct working directory and that file should be there. Is there any sandbox code in setuptools that might affect this?

The setup.py is here: https://github.com/ionelmc/pytest-benchmark/blob/fb397cb5866eaa76d918e5741724a6b504a73eb3/setup.py


@ghost
Copy link
Author

@ghost ghost commented Sep 6, 2015

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


If I had to guess, it's probably related to the refactor of findall, which I didn't include in the changelog, though the error you're getting sure is strange.

@ghost
Copy link
Author

@ghost ghost commented Sep 6, 2015

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


I was going to take the release offline as I won't be online for many hours. If another maintainer feels it's appropriate to pull that build, please do so.

@ghost
Copy link
Author

@ghost ghost commented Sep 6, 2015

Original comment by ionelmc (Bitbucket: ionelmc, GitHub: ionelmc):


Well I can't seem to reproduce this issue locally. I don't get what's different in Travis ...

@ghost
Copy link
Author

@ghost ghost commented Sep 6, 2015

Original comment by ionelmc (Bitbucket: ionelmc, GitHub: ionelmc):


More details: https://travis-ci.org/ionelmc/pytest-benchmark/jobs/79045015#L202

Looks like the created sdist doesn't have the CHANGELOG.rst file.

Could it be some ordering bug? os.listdir don't return files in consistent order.

@ghost
Copy link
Author

@ghost ghost commented Sep 7, 2015

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


Restore old behavior for calculating the base. Fixes failing test and fixes #425.

@ghost
Copy link
Author

@ghost ghost commented Sep 7, 2015

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


Issue #426 was marked as a duplicate of this issue.

@ghost ghost added major bug labels Mar 29, 2016
@ghost ghost closed this Mar 29, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
0 participants