New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop command should not pin the distribution version precisely #439

Closed
bb-migration opened this Issue Sep 17, 2015 · 7 comments

Comments

Projects
None yet
1 participant
@bb-migration

bb-migration commented Sep 17, 2015

Originally reported by: RonnyPfannschmidt (Bitbucket: RonnyPfannschmidt, GitHub: RonnyPfannschmidt)


When easy_install or pip installs console entry points (scripts), it does so by referencing the installed version of the package. The develop command uses the same logic to create executable scripts for a package under development.

However, it is common when developing a package that the version number will change, thereafter making the script references invalid (and causing errors when attempting to invoke those scripts).


@bb-migration

This comment has been minimized.

bb-migration commented Sep 27, 2015

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


@RonnyPfannschmidt

Can you provide an example replicating this issue?

As I try to describe the issue, I realize I'm not even sure under what circumstances the issue occurs.

I should think that the version number in the metadata is generated when setup.py develop is invoked, and that if the version information is changed (in code or implicitly through something like setuptools_scm), that won't affect the version of the package as installed unless the metadata is regenerated.

This leads me to think the issue is only relevant if the user regenerates metadata, such as by running the egg_info command or some other command that also invokes egg_info, such as test or sdist.

@bb-migration

This comment has been minimized.

bb-migration commented Sep 27, 2015

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


Extract _requirement_spec method for rendering the requirement specification for scripts. Ref #439.

@bb-migration

This comment has been minimized.

bb-migration commented Sep 27, 2015

Original comment by RonnyPfannschmidt (Bitbucket: RonnyPfannschmidt, GitHub: RonnyPfannschmidt):


think of something like using setuptools_scm, do a commit, run tox, then have your local virtualenv break
i already opened a pr regarding to the topic and will try to finish the unit/acceptance tests

@bb-migration

This comment has been minimized.

bb-migration commented Nov 24, 2015

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


Adapt the dist to suppress the version in the requirement when installing scripts under the develop command. Fixes #439.

@bb-migration

This comment has been minimized.

bb-migration commented Nov 24, 2015

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


Add VersionlessRequirement adapter to suppress the version number in a Distribution. Ref #439.

@bb-migration

This comment has been minimized.

bb-migration commented Nov 24, 2015

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


Update changelog; ref #439.

@bb-migration

This comment has been minimized.

bb-migration commented Nov 24, 2015

Original comment by RonnyPfannschmidt (Bitbucket: RonnyPfannschmidt, GitHub: RonnyPfannschmidt):


that solution is fabulous, well done

RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this issue Aug 21, 2016

RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this issue Aug 29, 2016

RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this issue Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment