New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix winbot/py 2.4.4 bug #44

Closed
bb-migration opened this Issue Jul 17, 2013 · 7 comments

Comments

Projects
None yet
1 participant
@bb-migration

bb-migration commented Jul 17, 2013

Originally reported by: agroszer (Bitbucket: agroszer, GitHub: agroszer)


http://winbot.zope.org/builders/setuptools_master%20py_244_win32/builds/2/steps/test/logs/stdio

ERROR: test_md5 (setuptools.tests.test_packageindex.TestContentCheckers)

Traceback (most recent call last):
File "c:\buildslave\setuptools_master_py_244_win32\build\setuptools\tests\test_packageindex.py", line 150, in test_md5
self.assertEqual(checker.hash.name, 'md5')
AttributeError: name


@bb-migration

This comment has been minimized.

bb-migration commented Jul 17, 2013

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


It appears the hashlib backport doesn't implement the full API of the canonical hashlib module (not supplying the .name attribute). Thanks so much for running these tests on Python 2.4.

@bb-migration

This comment has been minimized.

bb-migration commented Jul 17, 2013

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


Add compatibility for Python 2.4 when querying the hash name. Fixes #44

@bb-migration

This comment has been minimized.

bb-migration commented Jul 17, 2013

Original comment by agroszer (Bitbucket: agroszer, GitHub: agroszer):


welcome, FYI tests are run as "nightly" did not have the time yet to figure the change poller for hg

@bb-migration

This comment has been minimized.

bb-migration commented Jul 17, 2013

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


Bitbucket also provides a 'POST' service, which can POST details about commits (and possibly other activity) to the service to trigger a build. If there's an endpoint at winbot.zope.org to consume that API, I'd be happy to have the BB repo trigger a build.

@bb-migration

This comment has been minimized.

bb-migration commented Jul 18, 2013

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


I see the test is now passing. I'll release 0.9.6 shortly.

@bb-migration

This comment has been minimized.

bb-migration commented Jul 22, 2013

Original comment by dholth (Bitbucket: dholth, GitHub: dholth):


Set self.hash_name in init rather than using this function or relying on self.hash.name. Needed for pypy 1.9 as well as python 2.4.

@bb-migration

This comment has been minimized.

bb-migration commented Jul 22, 2013

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):


Python 2.4 issue was previously resolved. The PyPy issue was reported in #49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment