Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect sys.argv[0] for generated console scripts on Windows #459

Closed
ghost opened this issue Nov 7, 2015 · 1 comment
Closed

Incorrect sys.argv[0] for generated console scripts on Windows #459

ghost opened this issue Nov 7, 2015 · 1 comment
Labels

Comments

@ghost
Copy link

@ghost ghost commented Nov 7, 2015

Originally reported by: pombredanne (Bitbucket: pombredanne, GitHub: pombredanne)


The code that generates entry point console script return an incorrect value for sys.argv[0] on windows:
https://bitbucket.org/pypa/setuptools/src/4ce518784af886e6977fa2dbe58359d0fe161d0d/setuptools/command/easy_install.py?at=default&fileviewer=file-view-default#easy_install.py-2008

Even if the script was called from the CLI as XXXX, sys.argv[0] will be XXXX-script.py
It should instead by XXXX.

pip handles this by fixing sys.argv[0] in the generated launcher script for wheels here https://github.com/pypa/pip/blob/1da0ea13f3f0ab789edd62012d09bf69be045f68/pip/wheel.py#L416

distlib fixes sys.argv[0] here in a similar way in the launcher script :
https://bitbucket.org/pypa/distlib/src/6ada86eea2700f10edcd81f831139c6ae20edb74/distlib/scripts.py?at=default&fileviewer=file-view-default#scripts.py-55

Setuptools does not and it should IMHO.

See also this issue: pypa/pip#3233

And where this was discovered: pallets/click#365


@ghost ghost added minor bug labels Mar 29, 2016
ofek added a commit to ofek/setuptools that referenced this issue Aug 16, 2016
Patched sys.argv[0] before loading entry point
@ofek ofek mentioned this issue Aug 16, 2016
jaraco added a commit that referenced this issue Aug 20, 2016
Fix issue #459
@ofek
Copy link
Contributor

@ofek ofek commented Jun 14, 2020

@jaraco This is fixed

@pganssle pganssle closed this Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants