Recent changes broke ez_setup.py on Windows #477
Closed
Comments
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Originally reported by: niik (Bitbucket: niik, GitHub: niik)
This diff or commits 16007a2acbc5662238695f42d3d2ec1db09f0208 and 1e3d99eb4258dc5e7eb506509221c9d350acb9c3 broke downloading the setup zip on WIndows systems with powershell.
The return value from
_resolve_version
ends up being a unicode string which in turn makes the string interpolation in download_file_powershell produce a string similar to(new-object System.Net.WebClient).DownloadFile(u'https://pypi.python.org/packages/source/s/setuptools/setuptools-19.1.zip', u'setuptools-19.1.zip')
which obviously powershell doesn't like:The quick and dirty fix is to change the return line in
_resolve_version
toreturn doc['info']['version'].encode('ascii')
but I'm guessing switching to the something likestr.format
which does implicit conversion is preferable.The text was updated successfully, but these errors were encountered: