packaging 16.4 does not allow whitepace between requirement version conditions

Originally reported by: drcraig72 (Bitbucket: drcraig72, GitHub: Unknown)

---

Found in the release of setuptools 20.2.1, which vendors in packaging 16.4. It appears that packaging.requirements.Requirement does not comply with PEP-440's "Whitespace between a conditional operator and the following version identifier is optional, as is the whitespace around the commas.", per https://www.python.org/dev/peps/pep-0440/#version-specifiers. Instead, it fails when there is whitespace.

>>> from pkg_resources.extern.packaging.requirements import Requirement
>>> Requirement('Jinja2 >=2.7, <3')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/tmp/v/local/lib/python2.7/site-packages/pkg_resources/_vendor/packaging/requirements.py", line 94, in __init__
    requirement_string[e.loc:e.loc + 8]))
pkg_resources._vendor.packaging.requirements.InvalidRequirement: Invalid requirement, parse error at "'<3'"

But it succeeds when the whitespace is removed

>>> Requirement('Jinja2 >=2.7,<3')
<Requirement('Jinja2<3,>=2.7')>

Opened the same ticket on packaging at pypa/packaging#65

---

• Bitbucket: https://bitbucket.org/pypa/setuptools/issue/502

Original comment by thuandt (Bitbucket: thuandt, GitHub: thuandt):

---

+1 I faced some problem when install my tools using Requirement

        'click>=3.3, <=5.1',

Original comment by AdamChainz (Bitbucket: AdamChainz, GitHub: AdamChainz):

---

+1 failing with libfaketime failing on 'python-dateutil >= 1.3, != 2.0',

Original comment by flox (Bitbucket: flox, GitHub: flox):

---

.... add paramiko to this list

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):

---

Issue #501 was marked as a duplicate of this issue.

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):

---

I've pulled Setuptools 20.2.1 from PyPI to alleviate the pressure.

Original comment by thiefmaster (Bitbucket: thiefmaster, GitHub: thiefmaster):

---

Thanks!

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):

---

Add test capturing expectation that spaces between version specifiers should be allowed. Ref #502.

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):

---

@stevenk_ When this is resolved upstream, would you either send another pull request or simply let me know when it's ready to re-vendor?

Original comment by icordasc (Bitbucket: icordasc, GitHub: Unknown):

---

@jaraco 16.5 was just released with the fix for this.

Thank you @dstufft for releasing that.

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):

---

Issue #503 was marked as a duplicate of this issue.

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):

---

Bump vendored packaging to 16.5. Fixes #502.

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):

---

@msabramo, sorry to hear you're having trouble. There are tests in both setuptools and packaging to catch the reported error, so I'm confident it's fixed, though it's possible there's another edge case that wasn't considered.

I suspect given that you can't readily replicate the issue that it's environmental. Perhaps you have the latest setuptools but not the latest packaging. Or maybe you have setuptools 20.2.2 metadata and 20.2.1 code.

If you find that you're able to replicate a failure with a clean install of setuptools 20.2.2, post back here or file a new ticket (if it's not the same issue).

Original comment by msabramo (Bitbucket: msabramo, GitHub: msabramo):

---

@jaraco I agree that it's probably an environment problem. I was just able to rebuild the virtualenv and have it work. A few people here bumped into this -- I wonder if it happens when upgrading from setuptools 20.2.1 (was this version deleted from PyPI?) to 20.2.2.

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):

---

@msabramo Yes. 20.2.1 and 20.2 were both removed.

Original comment by kudos (Bitbucket: kudos, GitHub: kudos):

---

I'm still seeing this problem with 20.2.2 installing IPython.

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/pip/basecommand.py", line 122, in main
    status = self.run(options, args)
  File "/usr/lib/python3/dist-packages/pip/commands/install.py", line 290, in run
    requirement_set.prepare_files(finder, force_root_egg_info=self.bundle, bundle=self.bundle)
  File "/usr/lib/python3/dist-packages/pip/req.py", line 1266, in prepare_files
    req_to_install.extras):
  File "/usr/local/lib/python3.4/dist-packages/pkg_resources/__init__.py", line 2462, in requires
    dm = self._dep_map
  File "/usr/local/lib/python3.4/dist-packages/pkg_resources/__init__.py", line 2686, in _dep_map
    self.__dep_map = self._compute_dependencies()
  File "/usr/local/lib/python3.4/dist-packages/pkg_resources/__init__.py", line 2696, in _compute_dependencies
    current_req = packaging.requirements.Requirement(req)
  File "/usr/local/lib/python3.4/dist-packages/pkg_resources/_vendor/packaging/requirements.py", line 94, in __init__
    requirement_string[e.loc:e.loc + 8]))
pkg_resources.extern.packaging.requirements.InvalidRequirement: Invalid requirement, parse error at "'; sys.pl'"