Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setuptools' sdist doesn't use data_files while distutils does #521

Closed
ghost opened this issue Mar 23, 2016 · 2 comments
Closed

Setuptools' sdist doesn't use data_files while distutils does #521

ghost opened this issue Mar 23, 2016 · 2 comments

Comments

@ghost
Copy link

@ghost ghost commented Mar 23, 2016

Originally reported by: ionelmc (Bitbucket: ionelmc, GitHub: ionelmc)


Distutils has this: https://github.com/python/cpython/blob/master/Lib/distutils/command/sdist.py#L270-L282

However that code is not copies in the sdist provided by setuptools.

This can be problematic if you don't inlcude a file in MANIFEST.in but you have it in data_files - python's docs will most certainly mislead you as they say that sdist uses data_files: https://docs.python.org/3/distutils/sourcedist.html?highlight=data_files#specifying-the-files-to-distribute (last bullet)


@jaraco
Copy link
Member

@jaraco jaraco commented Aug 20, 2016

@jaraco
Copy link
Member

@jaraco jaraco commented Oct 30, 2016

I'm just going to mark this as a duplicate of #274.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant