Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for `tag_svn_revision` #619

Closed
jaraco opened this issue Jun 24, 2016 · 3 comments
Closed

Drop support for `tag_svn_revision` #619

jaraco opened this issue Jun 24, 2016 · 3 comments

Comments

@jaraco
Copy link
Member

@jaraco jaraco commented Jun 24, 2016

Integrated support for svn revisions has been largely removed from setuptools, but due to the specific distribution option tag_svn_revision there still exists code in setuptools that's linked to Subversion. This code should be deprecated and removed, and the setuptools_svn project should implement tagging of revisions following the model exemplified by the setuptools_scm project.

@jaraco
Copy link
Member Author

@jaraco jaraco commented Jun 24, 2016

Release 23.1.0 deprecates the option.

@jaraco jaraco closed this in 249f870 Jan 1, 2017
@jaraco
Copy link
Member Author

@jaraco jaraco commented Jan 2, 2017

Release 33.0.0 failed to deploy, as either Travis is explicitly setting that value, or perhaps it's lingering in a setup.cfg file somewhere.

@jaraco jaraco reopened this Jan 2, 2017
jaraco added a commit that referenced this issue Jan 2, 2017
@jaraco
Copy link
Member Author

@jaraco jaraco commented Jan 2, 2017

Oy. That version failed to pass integration tests. Packages that already have tag_svn_revision = 0 in their setup.cfg, which is probably most of them, will fail on this latest tag. Thank you integration tests for blocking the release.

jaraco added a commit that referenced this issue Jan 2, 2017
…istutils attempts to detect and set these values based on settings in setup.cfg as found in sdists built by earlier versions of setuptools. Ref #619.
jaraco added a commit that referenced this issue Jan 2, 2017
@jaraco jaraco closed this Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.