New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in class argument name in msvc.py #625

Closed
inklesspen opened this Issue Jul 3, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@inklesspen

inklesspen commented Jul 3, 2016

EnvironmentInfo takes an optional argument named vc_min_ver. However, on line 206, it is instantiated with an vc_ver_min, which will cause an exception.

This was reported in the #sqlalchemy freenode channel with this traceback.

@JGoutin JGoutin referenced this issue Jul 3, 2016

Merged

msvc fixes #627

@JGoutin

This comment has been minimized.

Contributor

JGoutin commented Jul 3, 2016

I fixed this.

@jaraco

This comment has been minimized.

Member

jaraco commented Jul 3, 2016

Fixed in #627 and release pending for 24.0.1 release.

@jaraco jaraco closed this Jul 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment