Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upImproperly installed from clean repo in clean environment #659
Comments
This comment has been minimized.
This comment has been minimized.
|
I notice several interesting things in the output of the All of those warnings indicate that setuptools isn't being used; only distutils is present at the time that the |
This comment has been minimized.
This comment has been minimized.
|
I don't know what typescript is doing, but when I check out the latest Sphinx and run This leads me to believe the issue is with the build script and not with Setuptools. I'm closing this ticket for now, but if you have additional information that implicates Setuptools or if you can distill the problem in a way that the issue can be more easily replicated, this ticket can be re-opened. |
jaraco
closed this
Jul 19, 2016
jaraco
added
the
invalid
label
Jul 19, 2016
This comment has been minimized.
This comment has been minimized.
fabled
commented
Jul 19, 2016
|
Why simply reverting that setuptools commits fixes the issue then?
|
This comment has been minimized.
This comment has been minimized.
fabled
commented
Jul 19, 2016
|
Hmm... it looked like it was reliable fixed by reverting the commit, but seems there's more to this issue. It can be some low-level issue that shows up in a weird way. Will look more into it. |
This comment has been minimized.
This comment has been minimized.
fabled
commented
Jul 19, 2016
|
Seems setup.py works reliably with python3.5.1, but the issue happens with python 2.7.12. Looking more into it. |
This comment has been minimized.
This comment has been minimized.
fabled
commented
Jul 20, 2016
|
Ok, figured out this. py-setuptools package was broken when built with python 2.7.x and no py-setuptools installed. Running bootstrap.py in build stage fixes this. It would be nice if setup.py would fail instead of succeed with incorrect results when there's no py-setuptools present. |
This comment has been minimized.
This comment has been minimized.
|
I'm not sure I follow, but I'm glad you've uncovered the cause. If you think there's something the Setuptools project can do, do feel free to suggest that (here or in another ticket). |
This comment has been minimized.
This comment has been minimized.
fabled
commented
Jul 20, 2016
|
When building setuptools on bootstrap environment (python 2.7.x only, no setuptools), one seems to be required to run the bootstrap.py scripts first so setuptools can use itself. If this is not done, currently running setup.py install will succeed (no error printed or error exit code returned) but will result in malfunctioning installation of setuptools. |
This comment has been minimized.
This comment has been minimized.
|
Aah! Yes. Now I see what you're saying. That should only be the case when installing setuptools from a repository checkout. Installing using the sdist or using the recommended bootstrapping technique (running https://bootstrap.pypa.io/ez_setup.py) will work. I'll see if there's something that setup.py can do to detect this condition and avoid this surprising behavior. |
jaraco
reopened this
Jul 20, 2016
jaraco
changed the title from
sphinx fails to install properly since setuptools 20.8.1
to
Improperly installed from clean repo in clean environment
Jul 20, 2016
This comment has been minimized.
This comment has been minimized.
|
I was able to replicate your findings thus: The issue isn't specific to Python 2.7 either. |
jaraco
closed this
in
80a2ff9
Jul 20, 2016
This comment has been minimized.
This comment has been minimized.
fabled
commented
Jul 20, 2016
|
Perfect! |
fabled commentedJul 19, 2016
I'm trying to package sphinx (http://www.sphinx-doc.org/en/stable/) version 1.4.5. But it fails with setuptools >= 20.8.1. 20.8.0 works still.
Seems that the only commit that went it:
dd5caef
Reverting that commit, makes packaging work again. Without it several files are not installed in install stage.
Or is there perhaps something wrong in sphinx setup.py ?
See diff of build logs with broken and working sphinx: