New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py_limited_api calculates extension module filename incorrectly #776

Closed
mithrandi opened this Issue Sep 7, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@mithrandi

mithrandi commented Sep 7, 2016

In

if use_abi3:
so_ext = get_config_var('SO')
filename = filename[:-len(so_ext)]
filename = filename + get_abi3_suffix()
a suffix of get_config_var("SO") is removed from the filename calculated by the superclass; however, the actual suffix that the superclass uses is get_config_var("EXT_SUFFIX"): https://github.com/python/cpython/blob/a9e7db8845551e5639e1fa8030a0482363501fa2/Lib/distutils/command/build_ext.py#L680. As these two values are the same on many platforms, this problem is often hidden, but where they are not the same (eg. CPython 3.3 on Linux), the generated extension filename is wrong and fails to import (it'll be something like foo.cpython-33m.abi3.so).

(Thanks to @dstufft for tracking down the exact misbehaviour causing this)

Lukasa added a commit to python-hyper/brotlipy that referenced this issue Sep 8, 2016

Lukasa added a commit to python-hyper/brotlipy that referenced this issue Sep 8, 2016

@jaraco jaraco closed this in #777 Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment