Closed
Description
Since commit bb45468, if a project's MANIFEST.in contains global-exclude .py[co]
, the archive generated with python setup.py sdist
will still contain all .pyc
/ .pyo
files.
The test below shows that this line worked in setuptools 28.4.0, and broke in setuptools 28.5.0.
I'm not sure whether this can be considered a bug: the previous implementation looked up patterns without any anchoring, whereas the new one forces users to explicitly include wildcards in their MANIFEST.in
.
However, I think this change should have been mentioned in the version Changelog.
diff --cc setuptools/tests/test_manifest.py
index 6360270,ef4beda..0000000
--- a/setuptools/tests/test_manifest.py
+++ b/setuptools/tests/test_manifest.py
@@@ -425,12 -464,22 +425,19 @@@ class TestFileListTest(TempDirTestCase)
assert file_list.files == ['b.txt']
self.assertWarnings()
+ file_list = FileList()
+ file_list.files = ['a.py', 'b.txt', l('d/c.pyc'), 'e.pyo']
+ file_list.process_template_line('global-exclude .py[co]')
+ file_list.sort()
+ assert file_list.files == ['a.py', 'b.txt']
+ self.assertNoWarnings()
+
# recursive-include
Metadata
Metadata
Assignees
Labels
No labels