Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MANIFEST.in `recursive-include` seems to be ignored. #886

Closed
idlesign opened this issue Dec 12, 2016 · 4 comments
Closed

MANIFEST.in `recursive-include` seems to be ignored. #886

idlesign opened this issue Dec 12, 2016 · 4 comments

Comments

@idlesign
Copy link
Member

@idlesign idlesign commented Dec 12, 2016

Regression since v28.5.0
Reported at idlesign/django-sitetree#222
Related to #764
Manifest example: https://github.com/idlesign/django-sitetree/blob/v1.6.0/MANIFEST.in

sdist creates a package without files mentioned in MANIFEST.in.

@idlesign
Copy link
Member Author

@idlesign idlesign commented Dec 14, 2016

The reason is that the following doesn't include *, so

recursive-include sitetree/templates .html

should rather be

recursive-include sitetree/templates *.html

I'll fix that in my packages, yet I have a suspicion that I'm not the only one.

@jaraco This one could be closed I think, but kept in mind.

@jaraco
Copy link
Member

@jaraco jaraco commented Dec 14, 2016

This seems to be another manifestation of #849. @timheap, it seems we're now in an awkward situation where we're half-compatible with the old behavior (supporting partial matches for global-exclude but not recursive-include).

It seems everybody's instinct is that the old behavior was undesirable. My temptation is to roll back the changes in #853 and clarify the change in behavior in the changelog for 28.5.0 (and of course the new version).

@timheap, how does that sound to you? Would you be willing to put together the patch?

@timheap
Copy link
Contributor

@timheap timheap commented Dec 14, 2016

@jaraco I agree that the old behaviour was undesirable. PR #890 reverts the changes in #853, and adds a note to the changelog about the change in behaviour.

@jaraco
Copy link
Member

@jaraco jaraco commented Dec 24, 2016

Excellent. Thanks @timheap for the fix, released in Setuptools 32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants