New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option 'python_requires' is not supported in configuration files #999

Closed
mbargull opened this Issue Mar 24, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@mbargull
Contributor

mbargull commented Mar 24, 2017

The option python_requires is not supported when metadata / options are loaded from setup.cfg via #862.

On a side note: Is it intended behavior that those package specific metadata / options may be given in all configuration files given by distutils.core.Distribution.find_config_files (i.e. including the user's .pydistutils.cfg, which is not specific to the package)?

@jaraco

This comment has been minimized.

Member

jaraco commented Mar 26, 2017

It's probably a design flaw that these option definitions need to be defined in two places, but that's what we've got. Would you consider creating a PR to address the missing option?

Is it intended behavior that those package specific metadata / options may be given in all configuration files?

That does seem like a defect, but perhaps ignorable. I can see how one might want to define the 'author' or 'maintainer' as users settings, though that does have some nasty implications around replicable builds. I don't think it was intentional that these other files are honored for these settings.

mbargull added a commit to mbargull/setuptools that referenced this issue Apr 7, 2017

@mbargull

This comment has been minimized.

Contributor

mbargull commented Apr 7, 2017

PR #1007 created.
Thanks for answering the question! I presumed this might be the case -- so let's just hope nobody does something that foolish to their .pydistutils.cfg 😄.

@jaraco jaraco closed this in abaf7c4 Apr 8, 2017

jaraco added a commit that referenced this issue Apr 8, 2017

Merge pull request #1007 from ma-ba/issue-999
Fixes #999: support python_requires and py_modules in configuration files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment