Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
addresses #436: Updating MANIFEST.in does not correctly update the package sdist creates #1014
The problem described in #436 is due to the fact that
This PR is surgical, in the sense that solves the issue by removing 2 lines of code. However after this modification the
I can see you mentioned in this ticket that you don't understand why this logic was authored in the first place. I don't know the reason either.
Perhaps it was a premature optimization. Perhaps it was a mistake.
Since there are no tests capturing the use-case that would have protected this functionality and because the functionality appears to only have detrimental effects, I'm inclined to accept the change and see if any adverse effects are reported, at which point we can distill a use-case and write a unit test to capture that expectation.
On further consideration, I think I've imagined a scenario where this functionality might have been expected - if a project were for whatever reason manually populating that file or using a third-party tool or other command to populate that file, then this change will cause those entries to be dropped. For that reason, I think this change is backward-incompatible and I'll release it as such.
added a commit
this pull request
Apr 15, 2017
However this makes sense in
Thanks for accepting the change, hoping not to break to much existing projects.
I found a project that broke with this change: https://bitbucket.org/vangheem/pyzipcode/src
This package installs properly before 35.0.0 and no longer does. Test script:
from pyzipcode import ZipCodeDatabase z = ZipCodeDatabase() z
@voidlily From my tests there is no regression from
Actually there is a regression when installing from a sdist file: see #1016 , sorry for the wrong assumption of an install form the develop tree.