New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Travis builds #1091

Merged
merged 2 commits into from Jul 31, 2017

Conversation

Projects
None yet
3 participants
@benoit-pierre
Member

benoit-pierre commented Jul 17, 2017

Update to the future defaults:

  • dist: trusty
  • sudo: required

Note:

  • include #1090
  • the version of PyPy now being tested is pypy-5.4: PyPy 5.4.0 [Python 2.7.10] (previously: PyPy 2.5.0 [Python 2.7.8])
  • pypy3-5.4 is also available, should it be added to the matrix?

@benoit-pierre benoit-pierre force-pushed the benoit-pierre:update_travis_builds branch from 0b915f5 to ce89a3f Jul 23, 2017

@benoit-pierre

This comment has been minimized.

Member

benoit-pierre commented Jul 23, 2017

Dropped #1090, now that the CI builds are working again.

.travis.yml Outdated
@@ -1,4 +1,5 @@
sudo: false
dist: trusty
sudo: required

This comment has been minimized.

@jaraco

jaraco Jul 24, 2017

Member

I think this is wrong. Sudo wasn't required before and won't be the default with Trusty. I don't think we need to change this setting.

This comment has been minimized.

@benoit-pierre

benoit-pierre Jul 24, 2017

Member

OK, after reading the blog post again, sudo: required will become the default in September, but only for precise, so I'll revert this part.

.travis.yml Outdated
@@ -1,4 +1,5 @@
sudo: false
dist: trusty

This comment has been minimized.

@jaraco

jaraco Jul 24, 2017

Member

Maybe it makes more sense to move to Xenial?

This comment has been minimized.

@benoit-pierre

benoit-pierre Jul 24, 2017

Member

Unfortunately, there's no support for Xenial. Trusty is the most recent supported version.

@jaraco

This comment has been minimized.

Member

jaraco commented Jul 24, 2017

I'm definitely in favor of testing against late releases of everything, so including PyPy 5.4 and PyPy3 5.4 sounds good to me.

@benoit-pierre benoit-pierre force-pushed the benoit-pierre:update_travis_builds branch from ce89a3f to fa0321f Jul 24, 2017

@benoit-pierre

This comment has been minimized.

Member

benoit-pierre commented Jul 24, 2017

mmm, I'm pretty sure pypy3-5.4 was working when I tested, but now the job is failing... Unfortunately, Travis' documentation does not detail what versions of PyPy are supported.

After a few tests, those appear to work:

  • pypy-5.4: PyPy 5.4.0 [Python 2.7.10]
  • pypy-5.7.1: PyPy 5.7.1 [Python 2.7.13]
  • pypy2.7-5.8.0: PyPy 5.8.0 [Python 2.7.13]
  • pypy3.5-5.8.0: PyPy 5.8.0-beta0 [Python 3.5.3]

So which combination shall be used?

benoit-pierre added some commits Jul 17, 2017

travis: update image
Update to the future defaults: `dist: trusty`.

@benoit-pierre benoit-pierre force-pushed the benoit-pierre:update_travis_builds branch from fa0321f to 01ad2ba Jul 28, 2017

@benoit-pierre

This comment has been minimized.

Member

benoit-pierre commented Jul 28, 2017

Using pypy and pypy3 is supported again! So I switched to that.

@jaraco

This comment has been minimized.

Member

jaraco commented Jul 28, 2017

Any idea if the failure in Py26 is due to the dist: trusty or if something else has changed in the ecosystem?

I'm really ready to drop support for Python 2.6, but I hate to conflate that change with this one.

@benoit-pierre

This comment has been minimized.

Member

benoit-pierre commented Jul 28, 2017

It's because of a change related to pytest-flake, looking into it.

@benoit-pierre

This comment has been minimized.

Member

benoit-pierre commented Jul 28, 2017

It's the switch from flake8 version 3.3.0 to 3.4.1.

@webknjaz

This comment has been minimized.

Contributor

webknjaz commented Jul 30, 2017

@benoit-pierre please also consider moving normal python: py_version instructions back to root-level matrix. I think it would look cleaner this way. Unless you're going to add some linters stage, which would run before the main test suite.

@jaraco jaraco merged commit c7e8fa8 into pypa:master Jul 31, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@benoit-pierre benoit-pierre deleted the benoit-pierre:update_travis_builds branch Jul 31, 2017

benoit-pierre referenced this pull request in pypa/pip Aug 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment