Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ssl.create_default_context and SNI if available #1190

Merged
merged 1 commit into from Nov 20, 2017
Merged

use ssl.create_default_context and SNI if available #1190

merged 1 commit into from Nov 20, 2017

Conversation

@gweis
Copy link
Contributor

@gweis gweis commented Nov 8, 2017

I ran into a ssl certificate verification problem using buildout and a private package index using SNI.

The usual workaround to make sure that the ssl cert of the private registry server defaults to the package index hostname was not possible this time, so I thought I'll fix it at the core and use SNI when connecting to a ssl server.

Happy to ammend this pull request in any way, but I do believe that something like this would be good to have as it also uses good practice ssl settings maintained in python core ssl.py module, and sticks to officially document methods in ssl module.

@jaraco jaraco merged commit 643bc84 into pypa:master Nov 20, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jaraco added a commit that referenced this pull request Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants