use ssl.create_default_context and SNI if available #1190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a ssl certificate verification problem using buildout and a private package index using SNI.
The usual workaround to make sure that the ssl cert of the private registry server defaults to the package index hostname was not possible this time, so I thought I'll fix it at the core and use SNI when connecting to a ssl server.
Happy to ammend this pull request in any way, but I do believe that something like this would be good to have as it also uses good practice ssl settings maintained in python core ssl.py module, and sticks to officially document methods in ssl module.