New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix `data_files` handling when installing from wheel #1220

Merged
merged 2 commits into from Dec 4, 2017

Conversation

Projects
None yet
2 participants
@benoit-pierre
Member

benoit-pierre commented Nov 30, 2017

Fix #1219.

@reinout

This comment has been minimized.

Contributor

reinout commented Dec 4, 2017

I tried your fix locally and it works like a charm.

I saw the problem when installing a django-celery wheel. Here's the first part of unzipping the wheel:

inflating: django_celery-3.1.10.data/data/djcelery/static/djcelery/style.css
inflating: django_celery-3.1.10.data/data/djcelery/templates/admin/djcelery/change_list.html
inflating: django_celery-3.1.10.data/data/djcelery/templates/djcelery/confirm_rate_limit.html
inflating: djcelery/init.py
inflating: djcelery/admin.py
inflating: djcelery/admin_utils.py
inflating: djcelery/app.py
inflating: djcelery/common.py
inflating: djcelery/db.py
...

So: exactly the same problem. And your fix works. So it looks good to merge!

@benoit-pierre

This comment has been minimized.

Member

benoit-pierre commented Dec 4, 2017

@reinout, @ikreymer: thanks for testing! I'll merge and release 38.2.4.

@benoit-pierre benoit-pierre merged commit b654e72 into pypa:master Dec 4, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benoit-pierre benoit-pierre deleted the benoit-pierre:fix_1219 branch Dec 4, 2017

@reinout

This comment has been minimized.

Contributor

reinout commented Dec 4, 2017

I've tested 38.2.4 and it works like a charm.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment