New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading version from a file #1359

Merged
merged 1 commit into from May 15, 2018

Conversation

Projects
None yet
5 participants
@jmbowman
Contributor

jmbowman commented May 14, 2018

Proposed resolution for #1358. Adds support for using "file:" to load the package version from a text file. It strips any leading or trailing whitespace, since trailing newlines are pretty likely in such a file.

@warsaw

This comment has been minimized.

warsaw commented May 15, 2018

I haven't tried this on live code, but it looks nice!

@pganssle

This comment has been minimized.

Member

pganssle commented May 15, 2018

I think I'm more or less fine with this, except that I think the resulting string should be more constrained.

Per discussion at PyCon sprints, we should just start by validating that it's a valid PEP 440 version, and if people complain about this restriction we can possibly add a mechanism for opting out.

@jmbowman jmbowman force-pushed the jmbowman:jmbowman/version_from_file branch from 7eeaa83 to a960ee1 May 15, 2018

@jaraco jaraco merged commit e0fd60c into pypa:master May 15, 2018

4 checks passed

codecov/patch 93.75% of diff hit (target 81.44%)
Details
codecov/project 81.45% (+0.01%) compared to 26b75f5
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jmbowman jmbowman deleted the jmbowman:jmbowman/version_from_file branch May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment