Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require network in tests #1368

Merged
merged 2 commits into from
May 17, 2018

Conversation

jmbowman
Copy link
Contributor

@jmbowman jmbowman commented May 16, 2018

Summary of changes

This fixes the only test cases which would fail if the network is unavailable. They were running a setup.py with packages listed in install_requires that usually aren't installed locally. This was causing 4 parameterized variants of the test case to fail if the network was unavailable, and triggered some AppVeyor failures when network access was slow or intermittent:

I resolved this by switching the packages listed in install_requires to ones which are dependencies of the test suite, and hence should always be installed by the time the test runs.

Pull Request Checklist

  • News fragment added in changelog.d. See documentation for details

@jmbowman jmbowman force-pushed the jmbowman/no_network_in_tests branch from 5716b00 to af30e01 Compare May 16, 2018 20:35
…ad focus on the behavior in egg_info as the namesake suggests.
@jmbowman jmbowman merged commit 50e3ba6 into pypa:master May 17, 2018
@jmbowman jmbowman deleted the jmbowman/no_network_in_tests branch May 17, 2018 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants