New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require network in tests #1368

Merged
merged 2 commits into from May 17, 2018

Conversation

Projects
None yet
2 participants
@jmbowman
Contributor

jmbowman commented May 16, 2018

Summary of changes

This fixes the only test cases which would fail if the network is unavailable. They were running a setup.py with packages listed in install_requires that usually aren't installed locally. This was causing 4 parameterized variants of the test case to fail if the network was unavailable, and triggered some AppVeyor failures when network access was slow or intermittent:

I resolved this by switching the packages listed in install_requires to ones which are dependencies of the test suite, and hence should always be installed by the time the test runs.

Pull Request Checklist

  • News fragment added in changelog.d. See documentation for details

@jmbowman jmbowman force-pushed the jmbowman:jmbowman/no_network_in_tests branch from 5716b00 to af30e01 May 16, 2018

Tests in test_egg_info no longer invoke 'setup.py install', but inste…
…ad focus on the behavior in egg_info as the namesake suggests.

@jmbowman jmbowman merged commit 50e3ba6 into pypa:master May 17, 2018

5 checks passed

codecov/patch 100% of diff hit (target 81.46%)
Details
codecov/project Absolute coverage decreased by -1.28% but relative coverage increased by +18.53% compared to 1252d1b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@jmbowman jmbowman deleted the jmbowman:jmbowman/no_network_in_tests branch May 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment