Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for PEP 425 support #1369

Merged
merged 1 commit into from May 17, 2018
Merged

Conversation

@jmbowman
Copy link
Contributor

@jmbowman jmbowman commented May 16, 2018

Summary of changes

When code for supporting PEP 425 compatibility tags was copied from pip in #1200, the unit tests weren't copied with it. I'm adding those to make sure we don't inadvertently break that functionality.

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details
@jmbowman jmbowman force-pushed the jmbowman:jmbowman/pep425tags_tests branch from 505a8de to 736ed24 May 16, 2018
@jmbowman
Copy link
Contributor Author

@jmbowman jmbowman commented May 16, 2018

It looks like this increased overall coverage by 0.5%.

@jmbowman jmbowman merged commit 41b3953 into pypa:master May 17, 2018
5 checks passed
5 checks passed
@codecov
codecov/patch 98.93% of diff hit (target 81.46%)
Details
@codecov
codecov/project 81.96% (+0.5%) compared to 1252d1b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@jmbowman jmbowman deleted the jmbowman:jmbowman/pep425tags_tests branch May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant