Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop testing Python 3.3 in Travis #1372

Merged
merged 1 commit into from
May 17, 2018

Conversation

jmbowman
Copy link
Contributor

Summary of changes

The Python 3.3 job in Travis failed in the last build on master because the new wheel release won't install on it. We planned on dropping 3.3 support soon anyway, so just stop testing it on Travis to avoid further job failures. We'll release one more version that officially supports Python 3.3 while incorporating all the latest fixes from master, and then the next one will fully remove support for it.

Pull Request Checklist

  • News fragment added in changelog.d. See documentation for details

@jmbowman jmbowman requested a review from jaraco May 17, 2018 15:01
@pganssle
Copy link
Member

This is already done in #1342 and is deferred to the next major release.

If installing wheel is breaking Travis, that is a bug in wheel, which should be using Requires-Python.

@pganssle pganssle closed this May 17, 2018
@pganssle
Copy link
Member

Actually, my bad, it looks like pip doesn't have a version that supports Python 3.3 and Requires-Python.

I think it's time to land #1342.

@jmbowman
Copy link
Contributor Author

I talked to @jaraco about this at the PyCon sprint earlier this morning, and our tentative plan was:

  • Merge this PR so we have clean Travis builds again.
  • Release 39.2.0 today with all the fixes already in master or ready to go in today (things that already passed Python 3.3 tests before the new wheel release came out).
  • Merge Drop support for EOL Python 3.3 #1342 immediately after that, so the next release would be 40.0.0 without Python 3.3 support.

Would you like to handle this differently? We could immediately merge #1342 and go straight to 40.0.0, just thought it would be nice to make the latest fixes available to any remaining Python 3.3 users before doing that.

@pganssle
Copy link
Member

Hm, this is a tiny bit complicated. I was hoping that we could just pin wheel at 0.30.0 until the 40.0.0 release (and just revert the single commit that does that), but it seems there are some more complicated dependencies in the test suite.

@pganssle
Copy link
Member

I think I have a more surgical PR in #1373.

I made it a single commit so it can be reverted as part of #1342.

@pganssle
Copy link
Member

Eh, #1373 seems like it's not quite working and I don't think it's worth being fiddly about. This approach works fine.

@pganssle pganssle reopened this May 17, 2018
@jmbowman jmbowman merged commit 4166bc9 into pypa:master May 17, 2018
@jmbowman jmbowman deleted the jmbowman/no_33_in_travis branch May 17, 2018 17:33
tryton-mirror-keeper pushed a commit to tryton/relatorio that referenced this pull request Dec 30, 2022
Latest setuptools does not support anymore Python 3.3
pypa/setuptools#1372
tryton-mirror-keeper pushed a commit to tryton/python-sql that referenced this pull request Dec 30, 2022
Latest setuptools does not support anymore Python 3.3
pypa/setuptools#1372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants