New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Microsoft Visual C++ Build Tools" link #1388

Merged
merged 2 commits into from Jul 10, 2018

Conversation

Projects
None yet
2 participants
@JGoutin
Contributor

JGoutin commented Jun 12, 2018

Summary of changes

Fix Microsoft Visual C++ Build Tools dead link.

Closes #1394

Pull Request Checklist

  • Changes have tests: Only change link in string.
  • News fragment added in changelog.d. See documentation for details
@pganssle

This comment has been minimized.

Member

pganssle commented Jun 29, 2018

According to @zooba in #1394:

The current best URL is https://visualstudio.microsoft.com/downloads/ and the title is "Build Tools for Visual Studio"

Given that Steve works for Microsoft I believe him - plus his link is https.

@pganssle

This comment has been minimized.

Member

pganssle commented Jun 29, 2018

I'm tempted to add a # pragma: nocover comment to the version switch, but I think it doesn't really make sense to do so, so we can just merge even with 0% diff coverage for now.

@JGoutin

This comment has been minimized.

Contributor

JGoutin commented Jun 29, 2018

The link I set in PR is in fact a redirection to the like you quoted. It look to work also in HTTPS. So I replaced the link.

@pganssle

Made a minor change adding a colon to be consistent with the other errors, otherwise LGTM.

@JGoutin

This comment has been minimized.

Contributor

JGoutin commented Jun 29, 2018

Normalized formatting.

@pganssle pganssle merged commit e50d77e into pypa:master Jul 10, 2018

5 checks passed

codecov/patch Coverage not affected when comparing 54ce659...baa9aea
Details
codecov/project 81.1% remains the same compared to 54ce659
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@JGoutin JGoutin deleted the JGoutin:issue-buildtooldeadlink branch Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment